fix Signal issue with Sanic 21.9 #63
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should I also update |
indam23
added a commit
to RasaHQ/pytest-sanic
that referenced
this pull request
Jul 1, 2022
|
I've ported this fix to #66 and added the changes mentioned in the issue |
|
@ancalita @melindaloubser1 there is also an official test library for Sanic (https://sanic.dev/en/plugins/sanic-testing/getting-started.html) which I’d recommend to use instead of pytest-sanic. I switched out the Rasa X code with that one and it was relatively straight forward if I remember correctly |
|
Thanks for the tip @wochinge 🙏 |
4 tasks
|
@yunstanford do you think this can be merged? This prevents people from using current sanic versions :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes